sashapolo commented on code in PR #5254:
URL: https://github.com/apache/ignite-3/pull/5254#discussion_r1965009360


##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/storage/state/rocksdb/TxStateRocksDbPartitionStorage.java:
##########
@@ -403,8 +382,6 @@ public void destroy() {
         try (WriteBatch writeBatch = new WriteBatch()) {
             clearStorageData(writeBatch);
 
-            writeBatch.delete(lastAppliedIndexAndTermKey);

Review Comment:
   > Shouldn't we keep this for older storage versions?
   
   No, because this key will actually be removed by `clearStorageData`, this 
call was always obsolete.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to