rpuch commented on code in PR #5241:
URL: https://github.com/apache/ignite-3/pull/5241#discussion_r1963036991
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -417,7 +424,11 @@ private IgniteBiTuple<Serializable, Boolean>
handleWriteIntentSwitchCommand(
UUID txId = cmd.txId();
- txFinisher.markFinished(txId, cmd.commit(), cmd.commitTimestamp(),
null);
+ if (!enabledColocationFeature) {
Review Comment:
This looks as a refactoring, it's not needed for anything else (like
elimination of duplication). I suggest deferring it. This PR is already huge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
