denis-chudov commented on code in PR #5244:
URL: https://github.com/apache/ignite-3/pull/5244#discussion_r1961987435
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceUtil.java:
##########
@@ -200,7 +201,14 @@ public static CompletableFuture<Void>
updatePendingAssignmentsKeys(
boolean isNewAssignments =
!tableCfgPartAssignments.equals(partAssignments);
- byte[] partAssignmentsBytes = Assignments.toBytes(partAssignments,
assignmentsTimestamp);
+ Assignments partAssignmentsPlanned = Assignments.of(partAssignments,
assignmentsTimestamp);
+ AssignmentsQueue partAssignmentsPending = new
AssignmentsQueue(partAssignmentsPlanned);
+
+ assert
partAssignmentsPlanned.equals(partAssignmentsPending.peekLast());
+
+ byte[] partAssignmentsPlannedBytes = partAssignmentsPlanned.toBytes();
+ byte[] partAssignmentsBytes = partAssignmentsPending.toBytes();
Review Comment:
I would also go to RebalanceUtil#PENDING_ASSIGNMENTS_PREFIX and
RebalanceUtil#pendingPartAssignmentsKey and rename them and change their
javadocs, to make them different from stable and planned assignment keys and
prefixes and denote that it is not a set of assignments, but queue of sets.
Also, there is a link to .md file which also tells about pending assignments,
it also needs to be fixed. Same for zone keys.
Also, please check the comments in
RebalanceUtil/RebalanceUtilEx/ZoneRebalanceUtil/RebalanceRaftGroupEventsListener,
etc. which describe the meta storage operations in pseudocode, for example,
things like this may be confusing:
`if partition.assignments.pending != calcPartAssignments`
Logging also became invalid, for example, in
RebalanceUtil#updatePendingAssignmentsKeys:
```
case PENDING_KEY_UPDATED:
LOG.info(
"Update metastore pending partitions key
[key={}, partition={}, table={}/{}, newVal={}]",
partAssignmentsPendingKey.toString(), partNum,
tableDescriptor.id(), tableDescriptor.name(),
partAssignments);
```
partAssignments is not a pending queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
