sashapolo commented on code in PR #5092:
URL: https://github.com/apache/ignite-3/pull/5092#discussion_r1961624215
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -243,6 +251,17 @@ public interface MetaStorageManager extends
IgniteComponent {
*/
Cursor<Entry> getLocally(ByteArray startKey, @Nullable ByteArray endKey,
long revUpperBound);
+ /**
+ * Returns a future of getting entries corresponding to the given keys
from the metastorage locally.
+ *
+ * <p>Never completes with a {@link CompactedException}.</p>
Review Comment:
Both approaches are viable, I'll leave the decision up to you. I just want
the javadocs to be consistent
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZonesUtil.java:
##########
@@ -74,12 +76,24 @@ public class DistributionZonesUtil {
/** Key prefix for zone's data nodes history. */
public static final String DISTRIBUTION_ZONE_DATA_NODES_HISTORY_PREFIX =
DISTRIBUTION_ZONE_DATA_NODES_PREFIX + "history.";
+ /** Key prefix for zone's data nodes history, in {@link ByteArray}
representation. */
+ public static final ByteArray
DISTRIBUTION_ZONE_DATA_NODES_HISTORY_PREFIX_BYTES =
Review Comment:
Why do you use `ByteArray` and not `byte[]` here?
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DataNodesManager.java:
##########
@@ -1013,7 +1048,7 @@ private CompletableFuture<Void> msInvokeWithRetry(
return null;
}
})
- .thenCompose(c -> nullCompletedFuture());
+ .thenApply(c -> null);
Review Comment:
I still don't understand this code, why is this line needed? What's going to
happen to the future from this line:
```
return msInvokeWithRetry(iifSupplier, attemptsLeft - 1, zone);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
