sanpwc commented on code in PR #5241:
URL: https://github.com/apache/ignite-3/pull/5241#discussion_r1961621822
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/TxManager.java:
##########
@@ -197,15 +193,15 @@ CompletableFuture<Void> cleanup(
* <p>The nodes to sends the request to are calculated by the placement
driver.
*
* @param commitPartitionId Commit partition id.
- * @param enlistedPartitions Enlisted partition groups.
+ * @param enlistedPartitions Enlisted partitions.
* @param commit {@code true} if a commit requested.
* @param commitTimestamp Commit timestamp ({@code null} if it's an abort).
* @param txId Transaction id.
* @return Completable future of Void.
*/
CompletableFuture<Void> cleanup(
TablePartitionId commitPartitionId,
- Collection<ReplicationGroupId> enlistedPartitions,
+ Collection<EnlistedPartitionGroup> enlistedPartitions,
Review Comment:
Too many similar entities `MutablePartitionEnlistment`,
`FinishingPartitionEnlistment`, `EnlistedPartitionGroup` with some carelessness
in javadocs:
- EnlistedPartitionGroup javadoc claims that it's `Partition enlistment
together with partition group ID`, meaning tableIds = Partition enlistment.
- MutablePartitionEnlistment is primaryNode + consistencyToken + tableIds
Do you have any ideas of how to make `MutablePartitionEnlistment`,
`FinishingPartitionEnlistment`, `EnlistedPartitionGroup` cleaner, probably
decreasing the number of classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
