sanpwc commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1961539555
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/InternalTransaction.java:
##########
@@ -143,4 +144,17 @@ IgniteBiTuple<ClusterNode, Long> enlist(
* @return The future.
*/
CompletableFuture<Void> kill();
+
+ /**
+ * Rolls back the transaction if the timeout is exceeded.
+ *
+ * @return The future.
+ */
+ default CompletableFuture<Void> rollbackTimeoutExceededAsync() {
+ return rollbackAsync();
+ }
+
+ default boolean isTimeoutExceeded() {
Review Comment:
Please specify guaranties of the method in the contract. It's not clear
whether the method will return true if logical timeout was exceeded or if it
was detected, etc? In other words if transactions with timeout 20 was started
at HLC timestamp t(10,10) will isTimeoutExceeded return true if HLC(t30, X)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
