Vladsz83 commented on code in PR #11866:
URL: https://github.com/apache/ignite/pull/11866#discussion_r1960195274
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandler.java:
##########
@@ -437,23 +434,23 @@ private PartitionHashRecord
calculateDumpedPartitionHash(Dump dump, String grpNa
/** {@inheritDoc} */
@Override public void complete(String name,
Collection<SnapshotHandlerResult<Map<PartitionKey,
PartitionHashRecord>>> results) throws IgniteCheckedException {
- Map<PartitionKey, List<PartitionHashRecord>> clusterHashes = new
HashMap<>();
- Map<ClusterNode, Exception> errs = new HashMap<>();
Review Comment:
I think not. Exceptions are processed and added differently. There are
several places where we get exceptions as a collections, one by one. And we do
not want create and wrap to a map manually. This is the target job of the
builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
