rpuch commented on code in PR #5242:
URL: https://github.com/apache/ignite-3/pull/5242#discussion_r1959585984
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/outgoing/OutgoingSnapshot.java:
##########
@@ -515,14 +563,20 @@ public boolean alreadyPassed(int tableId, RowId rowId) {
assert mvOperationsLock.isLocked() : "MV operations lock must be
acquired!";
if (mvPartitionDeliveryState == null) {
- // We haven't started sending MV data yet.
+ // We haven't even frozen the snapshot scope yet.
return false;
}
- if (finishedMvData()) {
+ // First, check if all MV data is delivered, because it can also be
empty.
+ if (mvPartitionDeliveryState.isExhausted() ||
!mvPartitionDeliveryState.containsTableId(tableId)) {
Review Comment:
Ok. But I see that `alreadyPassed()` is not renamed yet. Do you have any
suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
