sashapolo commented on code in PR #5226:
URL: https://github.com/apache/ignite-3/pull/5226#discussion_r1955682753
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ZoneResourcesManager.java:
##########
@@ -98,13 +109,14 @@ private ZoneResources(TxStateStorage txStateStorage) {
}
@TestOnly
+ @Nullable
public TxStatePartitionStorage txStatePartitionStorage(int zoneId, int
partitionId) {
ZoneResources resources = resourcesByZoneId.get(zoneId);
- assert resources != null : "No resources yet for zone " + zoneId;
- TxStatePartitionStorage partitionStorage =
resources.txStateStorage.getPartitionStorage(partitionId);
- assert partitionStorage != null : "No partition storage for zone " +
zoneId + " and partition " + partitionId;
+ if (resources == null) {
Review Comment:
This is test-only method. Previously it threw an assertion if resources
didn't exist. In order to write a unit test, I need it to return `null` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
