sashapolo commented on code in PR #5158:
URL: https://github.com/apache/ignite-3/pull/5158#discussion_r1954065534
##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -4497,6 +4509,36 @@ private static boolean waitForTopology(TestCluster
cluster, PeerId peerId, int e
return false;
}
+ /**
+ * Test if the actual value gets equal to expected within a given timeout.
The method will log all values the actual parameter
+ * has taken if the timeout is reached.
+ * @param expected the expected value
+ * @param actual the actual value, this should change over time and
therefore a supplier
+ * @param timeout the duration within the actual value should be the same
as the expected value
+ * @param <T> the type of expected and actual value
+ * @throws TimeoutException when the duration is reached
+ */
+ @SuppressWarnings("BusyWait")
+ private static <T> void assertWaitForCondition(T expected, Supplier<T>
actual, Duration timeout) throws TimeoutException {
Review Comment:
While I understand that this method can be helpful, I think it could be
written in a simpler way, reusing the existing method:
```
boolean success = waitForCondition(() -> {
T actualVal = actual.get();
if (Objects.equals(expected, actualVal)) {
return true;
} else {
//no matching result, save for debug
results.add(actualVal);
return false;
}
}, timeout.toMillis());
if (!success) {
fail(String.format("Timeout reached while waiting for expected result.
Expected: %s, Actual Results: %s", expected, results));
}
```
##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -2709,29 +2715,34 @@ public void
testAppendEntriesWhenFollowerIsInErrorState() throws Exception {
assertEquals(20, fsm.getLogs().size());
}
- @Test
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-21792";)
+ @RetryingTest(maxAttempts = 2)
+ @Timeout(value = 25, unit = TimeUnit.SECONDS)
Review Comment:
Do I understand correctly that the test can hang for some reason now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
