rpuch commented on code in PR #5213: URL: https://github.com/apache/ignite-3/pull/5213#discussion_r1952675289
########## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java: ########## @@ -1044,6 +1044,7 @@ private InternalTransaction startTxWithEnlistedPartition(int partId, boolean rea tx.enlist( tblPartId, + tblPartId.tableId(), Review Comment: This and similar comments are about places where `enlist()` is called. They fall into 2 groups: * a few of them (in unit tests) will work with any of `TablePartitionId` and `ZonePartitionId` instances; I switched them to use `ZonePartitionId` * others use not just `enlist()` but also `assignCommitPartition()` passing the same partition ID, so the compiler will not allow us to miss them when working on https://issues.apache.org/jira/browse/IGNITE-24343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org