sashapolo commented on code in PR #5187:
URL: https://github.com/apache/ignite-3/pull/5187#discussion_r1950392310
##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java:
##########
@@ -460,37 +460,44 @@ void txFinishCommandGetsReplicated(boolean commit) throws
Exception {
));
}
- List<CountExpectation> expectations = new ArrayList<>();
+ List<Executable> assertions = new ArrayList<>();
for (int i = 0; i < cluster.size(); i++) {
Review Comment:
You can use `IntStream.range().collect(toList())` here instead of a cycle,
this will save some code, like `finalI`. Current approach is also fine.
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReliableCatalogVersions.java:
##########
@@ -38,6 +38,8 @@ public ReliableCatalogVersions(SchemaSyncService
schemaSyncService, CatalogServi
/**
* Returns Catalog version corresponding to the given timestamp.
*
+ * <p>This should only be used when the startup procedure is complete.
Review Comment:
I think it would also be beneficial specify "why" it can only be used after
the startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
