sanpwc commented on code in PR #5179:
URL: https://github.com/apache/ignite-3/pull/5179#discussion_r1948498418


##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java:
##########
@@ -397,6 +395,11 @@ void testDataRebalance(boolean truncateRaftLog) throws 
Exception {
 
         setPrimaryReplica(newNode, zonePartitionId);
 
+        // Wait for the data to appear. At the moment of writing, we don't 
have any partition safe time to wait for and
+        // the primary replica has been assigned manually, so there's no 
guarantee that the data has been replicated.
+        // Not using "assertTrue" on purpose, the next line will produce a 
nicer error message.
+        waitForCondition(() -> kvView1.getAll(null, 
data1.keySet()).equals(data1), 10_000L);

Review Comment:
   Please add a todo with a link to corresponding ticket 
https://issues.apache.org/jira/browse/IGNITE-22620



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to