oleg-vlsk commented on code in PR #11793:
URL: https://github.com/apache/ignite/pull/11793#discussion_r1947484280
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java:
##########
@@ -96,7 +119,19 @@ public class PerformanceStatisticsThinClientTest extends
AbstractPerformanceStat
@Override protected void afterTestsStopped() throws Exception {
super.afterTestsStopped();
- thinClient.close();
+ stopAllGrids();
Review Comment:
The `stopAllGrids` method doesn't stop thin clients.
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java:
##########
@@ -66,12 +81,20 @@ public class PerformanceStatisticsThinClientTest extends
AbstractPerformanceStat
/** Thin client. */
private static IgniteClient thinClient;
+ /** */
+ @Parameterized.Parameter
+ public CacheAtomicityMode atomicityMode;
+
+ /** */
+ @Parameterized.Parameters(name = "atomicity={0}")
Review Comment:
`atomicityMode` to be consistent?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java:
##########
@@ -96,7 +119,19 @@ public class PerformanceStatisticsThinClientTest extends
AbstractPerformanceStat
@Override protected void afterTestsStopped() throws Exception {
super.afterTestsStopped();
- thinClient.close();
+ stopAllGrids();
+ }
+
+ /** {@inheritDoc} */
+ @Override protected void beforeTest() throws Exception {
+ thinClient.getOrCreateCache(new ClientCacheConfiguration()
Review Comment:
When the `getOrCreateCache` method is called on an existing cache, it
ignores the configuration passed as a parameter (as noted in the Javadoc). As a
result, all your tests are run with the same atomicity mode twice (whichever
mode was used in the initial configuration).
Starting new grids before each test is perfectly reasonable since it doesn’t
take up much time. You can opt for this approach if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
