alievmirza commented on code in PR #5083:
URL: https://github.com/apache/ignite-3/pull/5083#discussion_r1938950605
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/StateMachine.java:
##########
@@ -102,8 +102,10 @@ public interface StateMachine {
* {@link #onConfigurationCommitted(Configuration)} as full configuration
entry is provided.
*
* @param conf committed configuration
+ * @param lastAppliedIndex Last applied index.
+ * @param lastAppliedTerm Last applied term.
*/
- default void onRawConfigurationCommitted(ConfigurationEntry conf) {
+ default void
onConfigurationCommittedWithLastAppliedIndexAndTerm(ConfigurationEntry conf,
long lastAppliedIndex, long lastAppliedTerm) {
Review Comment:
fixed
##########
modules/raft-api/src/main/java/org/apache/ignite/internal/raft/service/RaftGroupListener.java:
##########
@@ -61,8 +61,14 @@ class ShutdownException extends RuntimeException {
* Called when a configuration is committed (that is, written to a
majority of the group).
*
* @param config Configuration that was committed.
+ * @param lastAppliedIndex Last applied index.
+ * @param lastAppliedTerm Last applied term.
*/
- default void onConfigurationCommitted(CommittedConfiguration config) {
+ default void onConfigurationCommittedWithLastAppliedIndexAndTerm(
Review Comment:
fixed
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java:
##########
@@ -237,15 +237,16 @@ public interface KeyValueStorage extends
ManuallyCloseable {
* Saves an arbitrary storage configuration as a byte array.
*
* @param configuration Configuration bytes.
- * @param index Operation's index.
- * @param term Operation's term.
+ * @param lastAppliedIndex Last applied index.
+ * @param lastAppliedTerm Last applied term.
*/
- void saveConfiguration(byte[] configuration, long index, long term);
+ void saveConfigurationWithLastAppliedIndexAndTerm(byte[] configuration,
long lastAppliedIndex, long lastAppliedTerm);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
