Re: [PR] IGNITE-24221 Implement new benchmarks that cover creating a distribution zone and table [ignite-3]

[via GitHub]

sk0x50 commented on code in PR #5081:
URL: https://github.com/apache/ignite-3/pull/5081#discussion_r1925369531


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/benchmark/AbstractMultiNodeBenchmark.java:
##########
@@ -90,25 +90,35 @@ public void nodeSetUp() throws Exception {
         startCluster();
 
         try {
-            var queryEngine = igniteImpl.queryEngine();
+            // Create a default zone on the cluster's start-up.
+            createDefaultZoneOnStartup();
 
-            var createZoneStatement = "CREATE ZONE IF NOT EXISTS " + ZONE_NAME 
+ " WITH partitions=" + partitionCount()
-                    + ", replicas=" + replicaCount() + ", storage_profiles ='" 
+ DEFAULT_STORAGE_PROFILE + "'";
-
-            getAllFromCursor(
-                    await(queryEngine.queryAsync(
-                            SqlPropertiesHelper.emptyProperties(), 
igniteImpl.observableTimeTracker(), null, null, createZoneStatement
-                    ))
-            );
-
-            createTable(TABLE_NAME);
+            // Create a default table on the cluster's start-up.
+            createDefaultTableOnStartup();
         } catch (Throwable th) {
             nodeTearDown();
 
             throw th;
         }
     }
 
+    protected void createDefaultZoneOnStartup() {
+        var queryEngine = igniteImpl.queryEngine();
+
+        var createZoneStatement = "CREATE ZONE IF NOT EXISTS " + ZONE_NAME + " 
WITH partitions=" + partitionCount()
+                + ", replicas=" + replicaCount() + ", storage_profiles ='" + 
DEFAULT_STORAGE_PROFILE + "'";
+
+        getAllFromCursor(

Review Comment:
   Switched to using public API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org