tkalkirill commented on code in PR #5090:
URL: https://github.com/apache/ignite-3/pull/5090#discussion_r1924862024
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/freelist/PagesList.java:
##########
@@ -91,6 +91,7 @@ public abstract class PagesList extends DataStructure {
/** Logger. */
protected final IgniteLogger log;
+ private final boolean debugLogEnabled;
Review Comment:
Please add a comment that this is for optimization.
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/replacement/DelayedPageReplacementTracker.java:
##########
@@ -185,7 +185,9 @@ public void waitUnlock(FullPageId id) {
boolean interrupted = false;
while (locked.contains(id)) {
- log.debug("Found replaced page which is being written to
page store, wait for finish replacement [id={}]", id);
+ if (log.isDebugEnabled()) {
Review Comment:
Why don't you use the field?
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/freelist/PagesList.java:
##########
@@ -399,7 +404,9 @@ private void flushBucketsCache(IoStatisticsHolder
statHolder) throws IgniteInter
}
if (lockedPages != 0) {
- log.info("Several pages were locked and weren't flushed on disk
[grp={}, lockedPages={}]", grpName, lockedPages);
+ if (log.isInfoEnabled()) {
Review Comment:
Why don't you use the field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
