ygerzhedovich commented on code in PR #5038:
URL: https://github.com/apache/ignite-3/pull/5038#discussion_r1923449656


##########
modules/api/src/main/java/org/apache/ignite/compute/BroadcastJobTarget.java:
##########
@@ -72,6 +73,18 @@ static BroadcastJobTarget nodes(Set<ClusterNode> nodes) {
      * @return Job target.
      */
     static BroadcastJobTarget table(String tableName) {
-        return new TableJobTarget(tableName);
+        return table(QualifiedName.parse(tableName));

Review Comment:
   should javadoc will be updated regarding what tableName is?



##########
modules/api/src/main/java/org/apache/ignite/compute/BroadcastJobTarget.java:
##########
@@ -72,6 +73,18 @@ static BroadcastJobTarget nodes(Set<ClusterNode> nodes) {
      * @return Job target.
      */
     static BroadcastJobTarget table(String tableName) {
-        return new TableJobTarget(tableName);
+        return table(QualifiedName.parse(tableName));
+    }
+
+    /**
+     * Creates a job target for partitioned execution. For each partition in 
the provided table the job will be executed on a node that
+     * holds the primary replica.
+     *
+     * @param tableName Table name.

Review Comment:
   the same,  seems it should be mention not just a table name, but a fully 
qualified table name together with schema



##########
modules/api/src/main/java/org/apache/ignite/lang/TableNotFoundException.java:
##########
@@ -37,6 +38,15 @@ public TableNotFoundException(String schemaName, String 
tableName) {
         super(TABLE_NOT_FOUND_ERR, "The table does not exist [name=" + 
canonicalName(schemaName, tableName) + ']');
     }
 
+    /**
+     * Creates an exception with the given table name.
+     *
+     * @param tableName Table name.
+     */
+    public TableNotFoundException(QualifiedName tableName) {
+        super(TABLE_NOT_FOUND_ERR, "The table does not exist [name=" + 
tableName.toCanonicalForm() + ']');

Review Comment:
   can we use the new introduced method for the first constructor?



##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogService.java:
##########
@@ -65,24 +65,45 @@ public interface CatalogService extends 
EventProducer<CatalogEvent, CatalogEvent
 
     @Nullable Catalog catalog(int catalogVersion);
 
-    @Nullable CatalogTableDescriptor table(String tableName, long timestamp);
+    /**
+     * Returns table descriptor by the given schema name and table name at 
given timestamp.
+     *
+     * @return Table descriptor or {@code null} if table not found.
+     */
+    @Nullable CatalogTableDescriptor table(String schemaName, String 
tableName, long timestamp);
 
+    /**
+     * Returns table descriptor by the given table ID and catalog version.

Review Comment:
   javadoc is not matched with method signature



##########
modules/platforms/dotnet/Apache.Ignite.Tests/Linq/LinqSqlGenerationTests.cs:
##########
@@ -40,115 +40,115 @@ public partial class LinqSqlGenerationTests
 
     [Test]
     public void TestSelectOneColumn() =>
-        AssertSql("select _T0.KEY from PUBLIC.tbl1 as _T0", q => q.Select(x => 
x.Key).ToList());
+        AssertSql("select _T0.KEY from PUBLIC.TBL1 as _T0", q => q.Select(x => 
x.Key).ToList());

Review Comment:
   I don't understand why you changed tablename to uppercase everywhere - SQL 
is case-insensitive in these cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to