Pochatkin commented on code in PR #4968: URL: https://github.com/apache/ignite-3/pull/4968#discussion_r1901793802
########## modules/spring/spring-data-ignite/build.gradle: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +apply from: "$rootDir/buildscripts/java-core.gradle" +apply from: "$rootDir/buildscripts/publishing.gradle" +apply from: "$rootDir/buildscripts/java-junit5.gradle" + +description = "spring-data-ignite" + +java { + sourceCompatibility = JavaVersion.VERSION_17 + targetCompatibility = JavaVersion.VERSION_17 +} + +dependencies { + implementation project(':ignite-client') + implementation project(":ignite-jdbc") + implementation libs.spring.boot + implementation libs.spring.boot.autoconfigure + implementation libs.spring.data.jdbc + + testImplementation libs.spring.boot.test + testImplementation libs.assertj.core + testImplementation(testFixtures project(':ignite-runner')) Review Comment: Please use '(' chat or not everywher ########## modules/spring/spring-data-ignite/src/main/java/org/apache/ignite/data/IgniteDialect.java: ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.data; + +import java.util.Collections; +import java.util.Set; +import org.springframework.data.relational.core.dialect.AbstractDialect; +import org.springframework.data.relational.core.dialect.ArrayColumns; +import org.springframework.data.relational.core.dialect.LimitClause; +import org.springframework.data.relational.core.dialect.LockClause; +import org.springframework.data.relational.core.sql.IdentifierProcessing; +import org.springframework.data.relational.core.sql.IdentifierProcessing.LetterCasing; +import org.springframework.data.relational.core.sql.IdentifierProcessing.Quoting; +import org.springframework.data.relational.core.sql.LockOptions; +import org.springframework.util.Assert; +import org.springframework.util.ClassUtils; + +/** + * Implementation of Ignite-specific dialect. + */ +public class IgniteDialect extends AbstractDialect { + + /** + * Singleton instance. + */ + public static final IgniteDialect INSTANCE = new IgniteDialect(); + + private IgniteDialect() {} + + private static final LimitClause LIMIT_CLAUSE = new LimitClause() { + + @Override + public String getLimit(long limit) { + return "LIMIT " + limit; + } + + @Override + public String getOffset(long offset) { + return "OFFSET " + offset; + } + + @Override + public String getLimitOffset(long limit, long offset) { + return String.format("OFFSET %d ROWS FETCH FIRST %d ROWS ONLY", offset, limit); + } + + @Override + public Position getClausePosition() { + return Position.AFTER_ORDER_BY; + } + }; + + static class IgniteArrayColumns implements ArrayColumns { + + @Override + public boolean isSupported() { + return true; + } + + @Override + public Class<?> getArrayType(Class<?> userType) { + + Assert.notNull(userType, "Array component type must not be null"); + + return ClassUtils.resolvePrimitiveIfNecessary(userType); + } + } + + @Override + public LimitClause limit() { + return LIMIT_CLAUSE; + } + + static final LockClause LOCK_CLAUSE = new LockClause() { + + @Override + public String getLock(LockOptions lockOptions) { + return ""; + } + + @Override + public Position getClausePosition() { + return Position.AFTER_ORDER_BY; + } + }; + + @Override + public LockClause lock() { + return LOCK_CLAUSE; + } + + private final IgniteArrayColumns arrayColumns = new IgniteArrayColumns(); + + @Override + public ArrayColumns getArraySupport() { + return arrayColumns; + } + + @Override + public IdentifierProcessing getIdentifierProcessing() { + return IdentifierProcessing.create(Quoting.ANSI, LetterCasing.UPPER_CASE); + } + + @Override + public Set<Class<?>> simpleTypes() { + Review Comment: Remove empty line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
