vldpyatkov commented on code in PR #4984: URL: https://github.com/apache/ignite-3/pull/4984#discussion_r1901609938
########## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/DistributionAlgorithm.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.partitiondistribution; + +import java.util.Collection; +import java.util.List; + +/** + * Partition distribution algorithm. + */ +public interface DistributionAlgorithm { + + /** + * Generates an assignment by the given parameters. Review Comment: Add detail here. In particular, how is this method distinguished from the method below? ########## modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/PartitionDistributionUtils.java: ########## @@ -17,19 +17,21 @@ package org.apache.ignite.internal.partitiondistribution; +import static java.util.Collections.emptyList; import static java.util.stream.Collectors.toList; import static java.util.stream.Collectors.toSet; -import java.util.ArrayList; import java.util.Collection; -import java.util.HashSet; import java.util.List; import java.util.Set; /** * Stateless distribution utils that produces helper methods for an assignments distribution calculation. */ public class PartitionDistributionUtils { + + private static final DistributionAlgorithm DISTRIBUTION_ALGORITHM = new RendezvousDistributionFunction(); Review Comment: Are we going to add an ignite system property at least here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
