alievmirza commented on code in PR #4978:
URL: https://github.com/apache/ignite-3/pull/4978#discussion_r1899556799


##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -3433,10 +3436,83 @@ public void testNewPeersConfigurationAppliedListener() 
throws Exception {
                 return false;
             }, 10_000));
 
-            verify(raftGrpEvtsLsnr, 
times(1)).onNewPeersConfigurationApplied(List.of(newPeer), List.of(newLearner));
+            verify(raftGrpEvtsLsnr, 
times(1)).onNewPeersConfigurationApplied(eq(List.of(newPeer)), 
eq(List.of(newLearner)), anyLong(), anyLong());
         }
     }
 
+    @Test
+    public void 
testIndexAndTermArePropagatedToOnNewPeersConfigurationApplied() throws 
Exception {

Review Comment:
   added such checks in the original test and added test for the case 3



##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -3433,10 +3436,83 @@ public void testNewPeersConfigurationAppliedListener() 
throws Exception {
                 return false;
             }, 10_000));
 
-            verify(raftGrpEvtsLsnr, 
times(1)).onNewPeersConfigurationApplied(List.of(newPeer), List.of(newLearner));
+            verify(raftGrpEvtsLsnr, 
times(1)).onNewPeersConfigurationApplied(eq(List.of(newPeer)), 
eq(List.of(newLearner)), anyLong(), anyLong());
         }
     }
 
+    @Test
+    public void 
testIndexAndTermArePropagatedToOnNewPeersConfigurationApplied() throws 
Exception {

Review Comment:
   added such checks in the original test and added test for the case 4



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to