kgusakov commented on code in PR #4843:
URL: https://github.com/apache/ignite-3/pull/4843#discussion_r1890142345
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/DisasterRecoveryManager.java:
##########
@@ -308,8 +318,25 @@ private Set<Assignment>
stableAssignmentsWithOnlyAliveNodes(TablePartitionId par
* @param manualUpdate Whether the update is triggered manually by user or
automatically by core logic.
* @return Future that completes when partitions are reset.
*/
- public CompletableFuture<Void> resetAllPartitions(String zoneName, String
tableName, boolean manualUpdate) {
- return resetPartitions(zoneName, tableName, emptySet(), manualUpdate);
+ public CompletableFuture<Void> resetAllPartitions(String zoneName, String
tableName, boolean manualUpdate, long triggerRevision) {
Review Comment:
fixed
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/DisasterRecoveryManager.java:
##########
@@ -569,26 +601,59 @@ private static Collection<CatalogZoneDescriptor>
filterZones(Set<String> zoneNam
return zoneDescriptors;
}
+ private CompletableFuture<Void> processNewRequest(DisasterRecoveryRequest
request) {
+ return processNewRequest(request, -1);
+ }
+
/**
* Creates new operation future, associated with the request, and writes
it into meta-storage.
*
* @param request Request.
* @return Operation future.
*/
- private CompletableFuture<Void> processNewRequest(DisasterRecoveryRequest
request) {
+ private CompletableFuture<Void> processNewRequest(DisasterRecoveryRequest
request, long revision) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
