isapego commented on code in PR #4902:
URL: https://github.com/apache/ignite-3/pull/4902#discussion_r1886861176
##########
modules/platforms/cpp/ignite/odbc/sql_connection.cpp:
##########
@@ -433,6 +433,7 @@ void sql_connection::transaction_start() {
network::data_buffer_owning response =
sync_request(protocol::client_operation::TX_BEGIN,
[&](protocol::writer &writer) {
writer.write_bool(false); // read_only.
+ writer.write((std::int64_t) 0); // timeoutMillis.
Review Comment:
```suggestion
writer.write<std::int64_t>(0); // timeoutMillis.
```
##########
modules/platforms/cpp/ignite/client/detail/transaction/transactions_impl.h:
##########
@@ -57,6 +57,7 @@ class transactions_impl {
IGNITE_API void begin_async(ignite_callback<transaction> callback) {
auto writer_func = [this](protocol::writer &writer) {
writer.write_bool(false); // readOnly.
+ writer.write((std::int64_t) 0); // timeoutMillis.
Review Comment:
```suggestion
writer.write<std::int64_t>(0); // timeoutMillis.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
