tkalkirill commented on code in PR #4900: URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886458434
########## modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteLoggerImpl.java: ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.logger; + +import java.lang.System.Logger.Level; +import java.util.Objects; +import java.util.function.Supplier; +import org.apache.ignite.internal.lang.IgniteStringFormatter; +import org.jetbrains.annotations.Nullable; + +class IgniteLoggerImpl implements IgniteLogger { + /** Logger delegate. */ + final System.Logger delegate; + + /** + * Creates logger facade for a given delegate. + * + * @param delegate The delegate to create facade for. + */ + IgniteLoggerImpl(System.Logger delegate) { + this.delegate = delegate; + } + + @Override + public void info(String msg, Object... params) { + logInternal(Level.INFO, msg, null, params); + } + + @Override + public void info(String msg, @Nullable Throwable th, Object... params) { + logInternal(Level.INFO, msg, th, params); + } + + @Override + public void info(Supplier<String> msgSupplier, @Nullable Throwable th) { + logInternalExceptional(Level.INFO, msgSupplier, th); + } + + @Override + public void info(String msg, @Nullable Throwable th) { + delegate.log(Level.INFO, msg, th); + } + + @Override + public void debug(String msg, Object... params) { + logInternal(Level.DEBUG, msg, null, params); + } + + @Override + public void debug(String msg, @Nullable Throwable th, Object... params) { + logInternal(Level.DEBUG, msg, th, params); + } + + @Override + public void debug(Supplier<String> msgSupplier, @Nullable Throwable th) { + logInternalExceptional(Level.DEBUG, msgSupplier, th); + } + + @Override + public void debug(String msg, @Nullable Throwable th) { + delegate.log(Level.DEBUG, msg, th); + } + + @Override + public void warn(String msg, Object... params) { + logInternal(Level.WARNING, msg, null, params); + } + + @Override + public void warn(String msg, @Nullable Throwable th, Object... params) { + logInternal(Level.WARNING, msg, th, params); + } + + @Override + public void warn(Supplier<String> msgSupplier, @Nullable Throwable th) { + logInternalExceptional(Level.WARNING, msgSupplier, th); + } + + @Override + public void warn(String msg, @Nullable Throwable th) { + delegate.log(Level.WARNING, msg, th); + } + + @Override + public void error(String msg, Object... params) { + logInternal(Level.ERROR, msg, null, params); + } + + @Override + public void error(String msg, @Nullable Throwable th, Object... params) { + logInternal(Level.ERROR, msg, th, params); + } + + @Override + public void error(Supplier<String> msgSupplier, @Nullable Throwable th) { + logInternalExceptional(Level.ERROR, msgSupplier, th); + } + + @Override + public void error(String msg, @Nullable Throwable th) { + delegate.log(Level.ERROR, msg, th); + } + + @Override + public void trace(String msg, Object... params) { + logInternal(Level.TRACE, msg, null, params); + } + + @Override + public void trace(String msg, @Nullable Throwable th, Object... params) { + logInternal(Level.TRACE, msg, th, params); + } + + @Override + public void trace(Supplier<String> msgSupplier, @Nullable Throwable th) { + logInternalExceptional(Level.TRACE, msgSupplier, th); + } + + @Override + public void trace(String msg, @Nullable Throwable th) { + delegate.log(Level.TRACE, msg, th); + } + + /** + * Logs a message with an optional list of parameters. + * + * @param level One of the log message level identifiers. Review Comment: I used refactoring tools to create an interface from a class and IDEA itself made the alignment into interfaces, but I did not touch this method, so the alignment did not change. Should I fix it or leave it as is? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
