AMashenkov commented on code in PR #4882:
URL: https://github.com/apache/ignite-3/pull/4882#discussion_r1881898607
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/row/RowSchema.java:
##########
@@ -101,4 +100,35 @@ public RowSchema build() {
return new RowSchema(types);
}
}
+
+ /**
+ * Creates a new schema based on original schema and provided mapping.
+ */
+ public static RowSchema map(RowSchema schema, int[] mapping) {
Review Comment:
It make no sense, why do want you call the method if its' contract says
nothing will be done?
Here, `null` becomes a magic constant.
BTW, I'd expect mapping is never null or empty here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
