AMashenkov commented on code in PR #4870:
URL: https://github.com/apache/ignite-3/pull/4870#discussion_r1880762320
##########
modules/client-common/src/main/java/org/apache/ignite/internal/client/table/MutableTupleBinaryTupleAdapter.java:
##########
@@ -256,6 +257,22 @@ public double doubleValue(int columnIndex) {
:
binaryTuple.doubleValue(validateSchemaColumnType(columnIndex,
ColumnType.DOUBLE));
}
+ /** {@inheritDoc} */
+ @Override
+ public BigDecimal decimalValue(String columnName) {
+ return tuple != null
+ ? tuple.decimalValue(columnName)
+ :
binaryTuple.decimalValue(validateSchemaColumnType(columnName,
ColumnType.DECIMAL), -1);
Review Comment:
fixed
##########
modules/client/src/test/java/org/apache/ignite/client/AbstractClientTableTest.java:
##########
@@ -87,6 +88,12 @@ protected static Tuple tupleVal(String name) {
return Tuple.create().set("name", name);
}
+ protected static void assertDecimalEqual(BigDecimal expected, BigDecimal
actual) {
+ if ((expected == null ^ actual == null) || (expected != null &&
expected.compareTo(actual) != 0)) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
