Re: [PR] IGNITE-23269: Sql. Reduce try/catch block used to wrap Exception into RUNTIME_ERR SqlException in ScanNode#push [ignite-3]

[via GitHub]

xtern commented on code in PR #4867:
URL: https://github.com/apache/ignite-3/pull/4867#discussion_r1880022622


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/ScanNode.java:
##########
@@ -131,13 +132,15 @@ private void push() throws Exception {
                     return;
                 }
             }
+        } catch (QueryCancelledException e) {
+            throw new QueryCancelledException(e);

Review Comment:
   ```suggestion
           } catch (QueryCancelledException | SqlException e) {
               throw e;
   ```
   What issue do you see with this approach?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org