ptupitsyn commented on code in PR #4869: URL: https://github.com/apache/ignite-3/pull/4869#discussion_r1878364244
########## modules/platforms/python/scripts/BuildWheels.ps1: ########## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +$PyVers="39","310","311","312","313" + +foreach ($Ver in $PyVers) +{ + & "$env:LOCALAPPDATA\Programs\Python\Python$Ver\python.exe" -m venv epy$Ver Review Comment: Is this the standard path? Can it be different? ########## modules/platforms/python/README.md: ########## @@ -32,6 +39,53 @@ $ pip install -r requirements/<your task>.txt You may also want to consult the `setuptools` manual about using `setup.py`. +### *C extension* + +The core of the package is an C++ extension. It shares the code with the Ignite C++ Client. The package is pre-built +for the most common platforms, but you may need to build it if your platform is not included. + +Linux building requirements: +- GCC (and G++); +- CMake version >=3.18; +- unixODBC (dev version of the package); +- OpenSSL (dev version of the package); +- Docker to build wheels; +- Supported versions of Python (3.9, 3.10, 3.11, 3.12 and 3.13). You can disable some of these versions + but you'd need to edit script for that. + +For building universal `wheels` (binary packages) for Linux, just invoke script `./scripts/create_distr.sh`. + +Windows building requirements: +- MSVC 14.x required, and it should be in path; Review Comment: ```suggestion - MSVC 14.x, and it should be in path; ``` ########## modules/platforms/python/scripts/build_wheels.sh: ########## @@ -0,0 +1,61 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +set -e -u -x + +PACKAGE_NAME=pyignite3 +PY_VERS="cp39 cp310 cp311 cp312 cp313" + +function repair_wheel { + wheel="$1" + if ! auditwheel show "$wheel"; then + echo "Skipping non-platform wheel $wheel" + else + auditwheel repair "$wheel" --plat "$PLAT" -w /wheels + fi +} + +for PY_VER in $PY_VERS; do + for PYBIN in /opt/python/*/bin; do + if [[ $PYBIN =~ ^(.*)$PY_VER/(.*)$ ]]; then + echo -e "\e[32m >>> \e[0m" + echo -e "\e[32m >>> Preparing a wheel for Python $PYBIN \e[0m" + echo -e "\e[32m >>> \e[0m" + + # Compile wheels + "${PYBIN}/pip" wheel /$PACKAGE_NAME/ --no-deps -w /wheels + + # Bundle external shared libraries into the wheels + for whl in /wheels/*.whl; do + if [[ $whl =~ ^(.*)$PY_VER-(.*)$ ]]; then + "${PYBIN}/pip" wheel /$PACKAGE_NAME/ --no-deps -w /wheels + repair_wheel "$whl" + fi + done + fi + done +done + +for whl in /wheels/*.whl; do + if [[ ! $whl =~ ^(.*)manylinux(.*)$ ]]; then + rm "$whl" + else + chmod 666 "$whl" Review Comment: Why is chmod required? ########## modules/platforms/python/README.md: ########## @@ -32,6 +39,53 @@ $ pip install -r requirements/<your task>.txt You may also want to consult the `setuptools` manual about using `setup.py`. +### *C extension* + +The core of the package is an C++ extension. It shares the code with the Ignite C++ Client. The package is pre-built Review Comment: ```suggestion The core of the package is a C++ extension. It shares the code with the Ignite C++ Client. The package is pre-built ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
