Phillippko commented on code in PR #4840:
URL: https://github.com/apache/ignite-3/pull/4840#discussion_r1873323755
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/SchemaManager.java:
##########
@@ -197,7 +215,7 @@ private void setColumnMapping(SchemaDescriptor schema, int
tableId) throws Execu
* @param ver Schema version (must not be higher than the latest version
saved to the Metastore).
* @return Schema representation.
*/
- private SchemaDescriptor loadSchemaDescriptor(int tblId, int ver) {
+ private @Nullable SchemaDescriptor loadOptionalSchemaDescriptor(int tblId,
int ver) {
Review Comment:
Javadoc still says "If called with a schema version for which the schema is
not yet saved to the Metastore, an exception will be thrown."
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/SchemaManager.java:
##########
@@ -182,12 +182,30 @@ private void setColumnMapping(SchemaDescriptor schema,
int tableId) throws Execu
SchemaDescriptor prevSchema = searchSchemaByVersion(tableId,
prevVersion);
if (prevSchema == null) {
- prevSchema = loadSchemaDescriptor(tableId, prevVersion);
+ prevSchema = loadRequeiredSchemaDescriptor(tableId, prevVersion);
}
schema.columnMapping(SchemaUtils.columnMapper(prevSchema, schema));
}
+ private SchemaDescriptor loadRequeiredSchemaDescriptor(int tblId, int ver)
{
Review Comment:
Requeired))
```suggestion
private SchemaDescriptor loadSchemaDescriptorStrict(int tblId, int ver) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
