korlov42 commented on code in PR #4837:
URL: https://github.com/apache/ignite-3/pull/4837#discussion_r1873031924
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/ItCastToSmallintTest.java:
##########
@@ -64,6 +64,11 @@ void clearTable() {
sql("DELETE FROM src");
}
+ @Override
+ protected int initialNodes() {
Review Comment:
does it make sense to change all similar tests?
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/DynamicParametersTest.java:
##########
@@ -244,19 +244,19 @@ public Stream<DynamicTest> testStandalone() {
.sql("SELECT CAST(? AS INTEGER)", 1)
.parameterTypes(nullable(NativeTypes.INT32))
// We are going to cast at runtime.
Review Comment:
these comments are not necessary anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
