korlov42 commented on code in PR #4827:
URL: https://github.com/apache/ignite-3/pull/4827#discussion_r1871136250
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImplTest.java:
##########
@@ -462,48 +464,6 @@ void testErrorOnCursorInitialization() throws
InterruptedException {
awaitContextCancellation(execNodes);
}
- /**
- * The very simple case where a query is cancelled in the middle of a
normal execution on non-initiator node.
- */
- @Test
- public void testCancelOnRemote() throws InterruptedException {
Review Comment:
technically, yep. We were cancelled any fragment, and the QueryCancellation
error was propagated to head of the query, and then back to remaining fragments.
but it never was in use, and now we have another mechanism for cancellation
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImplTest.java:
##########
@@ -1081,6 +1041,70 @@ public void timeoutFiredOnInitialization() throws
Throwable {
}
}
+ @Test
+ void executionsWithTheSameQueryIdMustNotInterfere() {
+ QueryPlan plan = prepare("SELECT * FROM test_tbl",
operationContext(null).build());
Review Comment:
replaced, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
