valepakh commented on code in PR #4815:
URL: https://github.com/apache/ignite-3/pull/4815#discussion_r1866120560
##########
modules/api/src/main/java/org/apache/ignite/table/TupleImpl.java:
##########
@@ -358,6 +360,17 @@ private void readObject(java.io.ObjectInputStream in)
throws IOException, ClassN
}
}
+ /**
+ * Serializes an object. Required to be implemented in pair with the
{@link #readObject(ObjectInputStream)} so that the
+ * {@code StructuredObjectMarshaller#fillStructuredObjectLayerFrom} will
actually call the {@link #readObject(ObjectInputStream)}.
+ *
+ * @param out Output object stream.
+ * @throws IOException If failed.
+ */
+ private void writeObject(ObjectOutputStream out) throws IOException {
+ out.defaultWriteObject();
Review Comment:
> This uses Java serialization, right?
More accurately - this is an implementation of the Java serialization since
the `Tuple` is serializable.
> Can we use `MARSHALLED_TUPLE` mode for tuples instead?
Do you mean `TupleWithSchemaMarshalling`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
