ptupitsyn commented on code in PR #4811:
URL: https://github.com/apache/ignite-3/pull/4811#discussion_r1865283730
##########
modules/platforms/dotnet/Apache.Ignite/Apache.Ignite.csproj:
##########
@@ -38,6 +38,7 @@
<PackageReference Include="NodaTime" Version="[3.*,)" />
<PackageReference Include="Remotion.Linq" Version="2.2.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions"
Version="[6.*,)" />
+ <PackageReference
Include="Microsoft.Extensions.DependencyInjection.Abstractions"
Version="[8.*,)" />
Review Comment:
Initially I planned to avoid this extra dependency in the core package by
moving the extensions to a separate package
(`Apache.Ignite.DependencyInjection` or something like that).
However,
[Microsoft.Extensions.DependencyInjection.Abstractions](https://www.nuget.org/packages/Microsoft.Extensions.DependencyInjection.Abstractions)
is small (~235 KB) and does not have any dependencies, so I guess we can keep
this here.
Thoughts?
##########
modules/platforms/dotnet/Apache.Ignite/IgniteServiceCollectionExtensions.cs:
##########
@@ -0,0 +1,167 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+namespace Apache.Ignite;
+
+using System;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.DependencyInjection.Extensions;
+
+/// <summary>
+/// Extension method for setting up Apache Ignite services in an <see
cref="Microsoft.Extensions.DependencyInjection.IServiceCollection" />.
+/// </summary>
+public static class IgniteServiceCollectionExtensions
+{
+ /// <summary>
+ /// Registers an <see cref="IgniteClientGroup" /> and an <see
cref="IIgnite" />.
Review Comment:
I don't think we can register `IIgnite` in the DI container, because it
requires async initialization through `IgniteClientGroup.GetIgniteAsync()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
