Vladsz83 commented on code in PR #11684:
URL: https://github.com/apache/ignite/pull/11684#discussion_r1861052024


##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/IgniteConvertletTable.java:
##########
@@ -53,6 +54,16 @@ private IgniteConvertletTable() {
         addAlias(IgniteOwnSqlOperatorTable.LENGTH, 
SqlStdOperatorTable.CHAR_LENGTH);
     }
 
+    /** {@inheritDoc} */
+    @Override public void registerOp(SqlOperator op, SqlRexConvertlet 
convertlet) {
+        super.registerOp(op, convertlet);

Review Comment:
   If we want to extend a default operator, we should take in account 
overriding a default converter like `StandardConvertletTable#convertPlus(..)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to