korlov42 commented on code in PR #4776:
URL: https://github.com/apache/ignite-3/pull/4776#discussion_r1860509156
##########
modules/api/src/main/java/org/apache/ignite/compute/JobExecutionOptions.java:
##########
@@ -36,6 +36,7 @@ public class JobExecutionOptions {
*
* @param priority Job execution priority.
* @param maxRetries Number of times to retry job execution in case of
failure, 0 to not retry.
+ *
Review Comment:
unrelated change
##########
modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java:
##########
@@ -48,9 +49,29 @@ public interface IgniteCompute {
* @param arg Argument of the job.
* @return Job execution object.
*/
+ default <T, R> JobExecution<R> submit(
+ JobTarget target,
+ JobDescriptor<T, R> descriptor,
+ @Nullable T arg
+ ) {
+ return submit(target, descriptor, null, arg);
+ }
+
+ /**
+ * Submits a {@link ComputeJob} of the given class for an execution on a
single node from a set of candidate nodes.
+ *
+ * @param <T> Job argument (T)ype.
+ * @param <R> Job (R)esult type.
+ * @param target Execution target.
+ * @param descriptor Job descriptor.
+ * @param cancellationToken Cancellation token or {@code null}.
+ * @param arg Argument of the job.
+ * @return Job execution object.
+ */
<T, R> JobExecution<R> submit(
JobTarget target,
JobDescriptor<T, R> descriptor,
+ @Nullable CancellationToken cancellationToken,
@Nullable T arg
);
Review Comment:
all `submit*` methods should be left intact, since they return
`JobExecution` which is handle itself containing `cancel` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
