ptupitsyn commented on code in PR #11685:
URL: https://github.com/apache/ignite/pull/11685#discussion_r1860229937
##########
modules/platforms/dotnet/Apache.Ignite.Core/Cache/ICache.cs:
##########
@@ -1064,5 +1064,10 @@ Task<ICollection<ICacheEntryProcessorResult<TK, TRes>>>
InvokeAllAsync<TArg, TRe
/// <param name="partition">Partition number.</param>
/// <returns><code>True</code>if partition was preloaded,
<code>False</code> if it doesn't belong to local node.</returns>
bool LocalPreloadPartition(int partition);
+
+ /// <summary>
+ /// Returns a value indicating whether this instance has platform
cache.
Review Comment:
```suggestion
/// Gets a value indicating whether this instance has platform cache.
```
##########
modules/platforms/dotnet/Apache.Ignite.Core/Cache/Configuration/PlatformCacheConfiguration.cs:
##########
@@ -89,6 +103,16 @@ internal void Write(IBinaryRawWriter writer)
writer.WriteString(KeyTypeName);
writer.WriteString(ValueTypeName);
writer.WriteBoolean(KeepBinary);
+
+ if (NodeFilter != null)
+ {
+ writer.WriteBoolean(true);
+
+ if (NodeFilter is JavaNodeFilter)
+ writer.WriteObject<object>(null);
+ else
+ writer.WriteObject(NodeFilter);
Review Comment:
Does this support `AttributeNodeFilter`? Can we add a test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
