ivanzlenko commented on code in PR #4791:
URL: https://github.com/apache/ignite-3/pull/4791#discussion_r1858537572


##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerRecoveryTest.java:
##########
@@ -431,7 +431,7 @@ private void stopComponents() throws Exception {
         );
     }
 
-    private static DataStorageManager createDataStorageManager(
+    private DataStorageManager createDataStorageManager(
             ConfigurationRegistry mockedRegistry,
             Path storagePath,
             StorageConfiguration config,

Review Comment:
   Looks like we can get rid of this parameters all together if are making this 
method non-static.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to