ascherbakoff commented on code in PR #4790:
URL: https://github.com/apache/ignite-3/pull/4790#discussion_r1858065006
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/schema/SchemaVersions.java:
##########
@@ -34,10 +35,20 @@ public interface SchemaVersions {
CompletableFuture<Integer> schemaVersionAt(HybridTimestamp timestamp, int
tableId);
/**
- * Obtains a schema version at 'now' in obedience to rules of Schema
Synchronization.
+ * Obtains a schema version at {@link HybridClock#now()} in obedience to
rules of Schema Synchronization.
*
* @param tableId ID of the table which schema to return.
* @return Future that will complete with the version.
*/
CompletableFuture<Integer> schemaVersionAtNow(int tableId);
+
+ /**
+ * Obtains a schema version at {@link HybridClock#current()} in obedience
to rules of Schema Synchronization.
+ * The method does not tick the hybrid clock. It may return an old schema
version in case the schema was just changed.
+ * Please use it where the handling of schema mismatch is possible.
+ *
+ * @param tableId ID of the table which schema to return.
+ * @return Future that will complete with the version.
+ */
+ CompletableFuture<Integer> weakSchemaVersionAtNow(int tableId);
Review Comment:
This method is not needed. Instead, schemaVersionAtNow should use
clockj.current()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
