kgusakov commented on code in PR #4764:
URL: https://github.com/apache/ignite-3/pull/4764#discussion_r1858065042
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -1020,6 +1009,37 @@ private CompletableFuture<Void>
scheduleTimers(CatalogZoneDescriptor zone, boole
return allOf(futures.toArray(CompletableFuture[]::new));
}
+ /**
+ * Returns metastore long view of {@link
org.apache.ignite.internal.hlc.HybridTimestamp} by revision.
+ *
+ * @param revision Metastore revision.
+ * @return Appropriate metastore timestamp or -1 if revision is already
compacted.
+ */
+ private long timestampByRevision(long revision) {
+ try {
+ return
metaStorageManager.timestampByRevisionLocally(revision).longValue();
+ } catch (CompactedException e) {
+ if (revision > 1) {
+ LOG.warn("Unable to retrieve timestamp by revision because of
meta storage compaction, [revision={}].", revision);
Review Comment:
Will do in the next PR, if you don't mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
