rpuch commented on code in PR #4790:
URL: https://github.com/apache/ignite-3/pull/4790#discussion_r1858011329
##########
modules/table/src/main/java/org/apache/ignite/internal/table/AbstractTableView.java:
##########
@@ -135,7 +135,7 @@ protected final <T> CompletableFuture<T>
withSchemaSync(@Nullable Transaction tx
private <T> CompletableFuture<T> withSchemaSync(@Nullable Transaction tx,
@Nullable Integer previousSchemaVersion, KvAction<T> action) {
CompletableFuture<Integer> schemaVersionFuture = tx == null
- ? schemaVersions.schemaVersionAtNow(tbl.tableId())
+ ? schemaVersions.weakSchemaVersionAtNow(tbl.tableId())
Review Comment:
Does it make sense to add a comment explaining the usage of the weak
version? Like 'We use the weak version of the method to avoid ticking the clock
(to decrease contention); it might return a stale schema, but the retry
mechanism implemented below allows us to be safe in this case'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
