timoninmaxim commented on code in PR #11612:
URL: https://github.com/apache/ignite/pull/11612#discussion_r1856941055


##########
modules/core/src/test/java/org/apache/ignite/cdc/CdcSelfTest.java:
##########
@@ -291,6 +294,15 @@ private void readAll(UserCdcConsumer cnsmr, boolean 
offsetCommit) throws Excepti
 
         checkMetrics(cdcMain, offsetCommit ? KEYS_CNT : ((KEYS_CNT + 3) * 2 + 
KEYS_CNT));
 
+        // Metric check awaits the CDC consumer to finish

Review Comment:
   Put a dot in the end of the comment.



##########
modules/core/src/test/java/org/apache/ignite/cdc/CdcSelfTest.java:
##########
@@ -291,6 +294,15 @@ private void readAll(UserCdcConsumer cnsmr, boolean 
offsetCommit) throws Excepti
 
         checkMetrics(cdcMain, offsetCommit ? KEYS_CNT : ((KEYS_CNT + 3) * 2 + 
KEYS_CNT));
 
+        // Metric check awaits the CDC consumer to finish
+        MetricRegistry mreg = getFieldValue(cdcMain, "mreg");

Review Comment:
   inline it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to