denis-chudov commented on code in PR #4755:
URL: https://github.com/apache/ignite-3/pull/4755#discussion_r1853938919
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/negotiation/LeaseNegotiator.java:
##########
@@ -124,9 +124,23 @@ public LeaseAgreement
getAndRemoveIfReady(ReplicationGroupId groupId) {
*
* @param groupId Group id.
* @param lease Lease to negotiate.
+ * @return If there is an existing agreement, the lease from agreement is
returned, otherwise the new agreement is created and
+ * {@code null} is returned.
*/
- public void createAgreement(ReplicationGroupId groupId, Lease lease) {
- leaseToNegotiate.put(groupId, new LeaseAgreement(lease));
+ @Nullable
+ public Lease createAgreement(ReplicationGroupId groupId, Lease lease) {
Review Comment:
removed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
