alex-plekhanov commented on code in PR #11580: URL: https://github.com/apache/ignite/pull/11580#discussion_r1852628109
########## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryRequest.java: ########## @@ -147,6 +152,10 @@ public class GridCacheQueryRequest extends GridCacheIdMessage implements GridCac /** */ private AffinityTopologyVersion topVer; + /** Set of keys that must be skiped during iteration. */ + @GridDirectCollection(KeyCacheObject.class) + private Collection<KeyCacheObject> skipKeys; Review Comment: 1. For example, you have 2 skipKeys and 10 nodes, in case of filtering on remote nodes you send additionaly 2 * 9 keys and receive 2 keys and 2 values less (but receive the same amount in case of insert only transactions). So, we can't be sure about reducing network usage. I think, in the typical usage, on the contrary, it will increase network usage. 2. Transformers can enlarge values as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org