denis-chudov commented on code in PR #4761:
URL: https://github.com/apache/ignite-3/pull/4761#discussion_r1851939923
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/AbstractClientService.java:
##########
@@ -153,6 +159,8 @@ public CompletableFuture<Boolean> connectAsync(PeerId
peerId) {
if (resp != null && resp.errorCode() == 0) {
readyConsistentIds.add(peerId.getConsistentId());
+ deadPeers.remove(peerId);
Review Comment:
We remove dead peer from deadPeers only after successful connect. It seems
to be the best and most natural place to do it.
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/ReplicatorGroupImpl.java:
##########
@@ -19,7 +19,7 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
+import java.util.Set;import java.util.concurrent.ConcurrentHashMap;
Review Comment:
I have no idea how it happened)
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
