timoninmaxim commented on code in PR #11660:
URL: https://github.com/apache/ignite/pull/11660#discussion_r1851552955


##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java:
##########
@@ -681,6 +682,8 @@ synchronized void initChannelHolders() {
         if (idx != -1)
             currDfltHolder = holders.get(idx);
 
+        Set<ClientChannelHolder> uniqueHolders = new HashSet<>();

Review Comment:
   Looks like, you don't need one more collection. You can base on existing 
logic:
   1. There is a loop over existing holders (see line 653)
   2. And there is a place where a new holder is created (see line 700)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to