Vladsz83 commented on code in PR #11659:
URL: https://github.com/apache/ignite/pull/11659#discussion_r1850780660
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/FunctionsTest.java:
##########
@@ -301,4 +301,48 @@ public void testCastToBoolean() {
assertQuery("SELECT CAST(CAST(? AS DECIMAL(2, 1)) AS BOOLEAN)")
.withParams(NULL_RESULT).returns(NULL_RESULT).check();
}
+
+ /** Tests NVL with different parameters data types. */
+ @Test
+ public void testNvl() {
+ // Result type is the least restrictive type for parameters.
+ assertQuery("select nvl('1', 2)").returns("1").check();
+ assertQuery("select nvl(1, '2')").returns("1").check();
+ assertQuery("select nvl(1, 2.0)").returns(new
BigDecimal("1.0")).check();
+ assertQuery("select nvl(1, 2::DOUBLE)").returns(1d).check();
+ assertQuery("select nvl(1::TINYINT,
2::SMALLINT)").returns((short)1).check();
+ assertQuery("select nvl(1.0, '2')").returns("1.0").check();
+ assertQuery("select nvl(null, 2)").returns(2).check();
+ assertQuery("select nvl(null, '2')").returns("2").check();
+ assertQuery("select nvl(null, null)").returns(NULL_RESULT).check();
+ assertQuery("select nvl(?, ?)").withParams("1",
2).returns("1").check();
+ assertQuery("select nvl(?, ?)").withParams(1,
"2").returns("1").check();
+ assertQuery("select nvl(?, ?)").withParams(1, 2d).returns(1d).check();
+ assertQuery("select nvl(?, ?)").withParams(null, 2).returns(2).check();
+ assertQuery("select nvl(?, ?)").withParams(null,
"2").returns("2").check();
+ assertQuery("select nvl(?, ?)").withParams(null,
null).returns(NULL_RESULT).check();
+ }
+
+ /** Tests DECODE with different parameters data types. */
+ @Test
+ public void testDecode() {
Review Comment:
Suggestion: tests like `assertQuery("select decode(2, '1', 1, '2',
2::DOUBLE)").returns(2.0).check();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
