sashapolo commented on code in PR #4720:
URL: https://github.com/apache/ignite-3/pull/4720#discussion_r1841761141
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/network/raft/SnapshotMetaResponse.java:
##########
@@ -20,11 +20,10 @@
import org.apache.ignite.internal.network.NetworkMessage;
import org.apache.ignite.internal.network.annotations.Transferable;
import
org.apache.ignite.internal.partition.replicator.network.PartitionReplicationMessageGroup;
-import org.apache.ignite.raft.jraft.entity.RaftOutter.SnapshotMeta;
/** Snapshot meta response message. */
@Transferable(PartitionReplicationMessageGroup.SNAPSHOT_META_RESPONSE)
public interface SnapshotMetaResponse extends NetworkMessage {
/** Snapshot meta. */
- SnapshotMeta meta();
+ PartitionSnapshotMeta meta();
Review Comment:
I think we also need to rename the request and response classes to show that
they are only applicable to partitions
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/network/PartitionReplicationMessageGroup.java:
##########
@@ -197,6 +198,10 @@ public interface PartitionReplicationMessageGroup {
* Message type for {@link UpdateMinimumActiveTxBeginTimeReplicaRequest}.
*/
short UPDATE_MINIMUM_ACTIVE_TX_TIME_REPLICA_REQUEST = 26;
+ /**
Review Comment:
```suggestion
/**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
