JAkutenshi commented on code in PR #4707:
URL: https://github.com/apache/ignite-3/pull/4707#discussion_r1840959806
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -443,8 +443,19 @@ private void updateLeaseBatchInternal() {
? lease.getLeaseholder()
: lease.proposedCandidate();
- ClusterNode candidate = nextLeaseHolder(assignments,
grpId, proposedLeaseholder);
+ ClusterNode candidate = nextLeaseHolder(stableAssignments,
grpId, proposedLeaseholder);
+ // if there wasn't a candidate among stable assignments
set then make attempt to select a candidate among pending set
+ if (candidate == null) {
+ Map<ReplicationGroupId, TokenizedAssignments>
pendingMap = assignmentsTracker.pendingAssignments();
+
+ if (pendingMap.containsKey(grpId)) {
+ Set<Assignment> pendingAssignments =
pendingMap.get(grpId).nodes();
+ candidate = nextLeaseHolder(pendingAssignments,
grpId, proposedLeaseholder);
+ }
+ }
Review Comment:
I doubt there, because in the first scenario from the ticket lease on B is
trying to expire (time is out), but we can't to find a proper candidate in this
lines. So, the case `lease.getExpirationTime().getPhysical() <
outdatedLeaseThreshold` is crucial there. But, may be I should add the pendings
check in `chooseCandidateAndCreateNewLease` too (not instead)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
