vladnovoren commented on code in PR #11634:
URL: https://github.com/apache/ignite/pull/11634#discussion_r1836726902


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java:
##########
@@ -1578,6 +1578,15 @@ void updateServicesTopologies(@NotNull final 
Map<IgniteUuid, Map<UUID, Integer>>
 
         try {
             updateServicesMap(deployedServices, fullTops);
+            for (Map.Entry<IgniteUuid, Map<UUID, Integer>> e : 
fullTops.entrySet()) {
+                // Checking if there are successful deployments.
+                // If none, service not deployed and must be removed from 
descriptors.
+                if (e.getValue().entrySet().stream().allMatch(nodeTop -> 
nodeTop.getValue() == 0)) {
+                    ServiceInfo desc = registeredServices.remove(e.getKey());
+                    if (desc != null)

Review Comment:
   fixed



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java:
##########
@@ -1578,6 +1578,15 @@ void updateServicesTopologies(@NotNull final 
Map<IgniteUuid, Map<UUID, Integer>>
 
         try {
             updateServicesMap(deployedServices, fullTops);
+            for (Map.Entry<IgniteUuid, Map<UUID, Integer>> e : 
fullTops.entrySet()) {

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to