nizhikov commented on code in PR #11633:
URL: https://github.com/apache/ignite/pull/11633#discussion_r1836050174
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/affinity/GridAffinityAssignmentCache.java:
##########
@@ -76,23 +76,23 @@ public class GridAffinityAssignmentCache {
* Affinity cache will shrink when total number of non-shallow (see {@link
HistoryAffinityAssignmentImpl})
* historical instances will be greater than value of this constant.
*/
- private final int MAX_NON_SHALLOW_HIST_SIZE =
getInteger(IGNITE_AFFINITY_HISTORY_SIZE, DFLT_AFFINITY_HISTORY_SIZE);
+ final int maxNonShallowHistSize = getInteger(IGNITE_AFFINITY_HISTORY_SIZE,
DFLT_AFFINITY_HISTORY_SIZE);
Review Comment:
Let's revert this and rename in another PR.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/affinity/GridAffinityAssignmentCache.java:
##########
@@ -76,23 +76,23 @@ public class GridAffinityAssignmentCache {
* Affinity cache will shrink when total number of non-shallow (see {@link
HistoryAffinityAssignmentImpl})
* historical instances will be greater than value of this constant.
*/
- private final int MAX_NON_SHALLOW_HIST_SIZE =
getInteger(IGNITE_AFFINITY_HISTORY_SIZE, DFLT_AFFINITY_HISTORY_SIZE);
+ final int maxNonShallowHistSize = getInteger(IGNITE_AFFINITY_HISTORY_SIZE,
DFLT_AFFINITY_HISTORY_SIZE);
/**
* Affinity cache will also shrink when total number of both shallow
({@link HistoryAffinityAssignmentShallowCopy})
* and non-shallow (see {@link HistoryAffinityAssignmentImpl}) historical
instances will be greater than
* value of this constant.
*/
- private final int MAX_TOTAL_HIST_SIZE = MAX_NON_SHALLOW_HIST_SIZE * 10;
+ final int maxTotalHistSize = maxNonShallowHistSize * 10;
Review Comment:
Let's revert this and rename in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
